search

jcoglan / restore

Simple remoteStorage server written in Node.js
293 stars 27 forks source link

fix a null[0] when ifMatch/ifNone exists but not numeric e.g. * #31

Closed muhmuhten closed 9 years ago

muhmuhten commented 9 years ago

browser was sending If-None-Match: *, causing "*".match(/\d+/)[0] → null[0].

raucao commented 9 years ago

FYI: tests are only failing in 0.8. Maybe let's remove it from the Travis config? Not sure if @jcoglan wants to keep supporting it, though.

silverbucket commented 9 years ago

yeah if im not mistaken ejs does not support node 0.8 anymore

On Fri, Apr 3, 2015, 11:43 Sebastian Kippe notifications@github.com wrote:

FYI: tests are only failing in 0.8. Maybe let's remove it from the Travis config? Not sure if @jcoglan https://github.com/jcoglan wants to keep supporting it, though.

— Reply to this email directly or view it on GitHub https://github.com/jcoglan/restore/pull/31#issuecomment-89237775.

jcoglan commented 9 years ago

Sorry, I realised I had some code to implement If-None-Match: * that I had not pushed. It's in https://github.com/jcoglan/restore/commit/b24d0fa0cd2e98f886bd151119fe748f155d517a.

jcoglan commented 9 years ago

The issue with Node 0.8 is fixed in https://travis-ci.org/jcoglan/restore/builds/57344912.