jcoglan / restore

Simple remoteStorage server written in Node.js
293 stars 27 forks source link

baseURL option support. #39

Open lesion opened 8 years ago

lesion commented 8 years ago

Needed if you want to host reStore without a domain for itself alone. Let's say you own your 'www.example.com' and want to host reStore at 'www.example.com/reStore' now you can.

This PR introduces a new baseURL option you can use for this.

lesion commented 8 years ago

Initially thought this was not a good idea 'cause your remoteStorage address would be user@domain/path but I cannot find a reason why this could be bad. Searched in remoteStorage specification and can't find if this is specified or not !

I'm trying laverna.cc with this PR and currently is not working (i'm stuck after oauth and before /storage call)

lesion commented 8 years ago

this last commit fix the issue, i'm currently using with this setup :)

raucao commented 8 years ago

Initially thought this was not a good idea 'cause your remoteStorage address would be user@domain/path but I cannot find a reason why this could be bad. Searched in remoteStorage specification and can't find if this is specified or not !

As long as Webfinger is there under the normal well-known URL(s), there's nothing that should prevent you from doing it that way. It's mostly a security question, because your storage is then on the same origin as other things, but it's not a problem per se.

untitaker commented 8 years ago

I'd rather call the variable basePath.

lesion commented 8 years ago

done

I'd rather call the variable |basePath|.