search

jcoglan / restore

Simple remoteStorage server written in Node.js
293 stars 27 forks source link

No more default digest in node.js 8 #44

Open vkoechli opened 7 years ago

vkoechli commented 7 years ago

When running reStore under node.js 8.4.0, trying to sign up a user returns a 500 error: <<The "digest" argument is required and must not be undefined>>. Supposedly a consequence of https://github.com/nodejs/node/pull/11305. The default used to be sha1, but that is no longer the case.

lesion commented 7 years ago

I've fixed this in my fork with this commit:

https://github.com/lesion/restore/commit/cc065ec37f5b4e30232c11a93d2d1ff7d0b62b8b

untitaker commented 7 years ago

@lesion if you're going to keep maintaining that fork I would suggest merging the commits from https://github.com/untitaker/morestore as well.

lesion commented 7 years ago

done, thanks for the suggestion.