search

jcoglan / vault

Generates safe passwords so you never need to remember them
https://getvau.lt
471 stars 64 forks source link

Workaround node-pw eating Ctrl-C / SIGINT. #23

Closed joewreschnig closed 7 years ago

joewreschnig commented 10 years ago

node-pw exits with code 0 (success) if you press Ctrl-C while entering your password. This is awful.

This installs a process exit handler for the duration of the password prompt that catches exiting with code 0 and instead exits with code 130. This is very slightly less awful.

There's a good chance you won't want this because it is a gross gross thing, but I need it for vault to work properly in shell scripts, and figured I might as well let you know node-pw is terrible. I've already filed https://github.com/substack/node-pw/pull/6 with a proper fix but it also seems dead.

jcoglan commented 10 years ago

I'd like to see the Travis build passing on both your pw patch and this one before I accept the PR.

joewreschnig commented 10 years ago

I would too. The failures in both cases have nothing to do with my changes and seem to be due to some changes in unrelated node packages.

jcoglan commented 10 years ago

I think I've resolved the errors in the vault build so you can try again if you like. You shouldn't need to change anything; the Travis build should pull in wake@0.3.4 which fixes the problem you were seeing.

joewreschnig commented 10 years ago

I'm not sure how to request a rebuild, or if I can do it at all. When I visit https://travis-ci.org/jcoglan/vault/builds/26401207 or any of the individual job pages I don't see the "Restart" button described in http://stackoverflow.com/questions/17606874/trigger-a-travis-ci-rebuild-without-pushing-a-commit, neither next to the double hamburger icon nor under the gear menu (ugh).

joewreschnig commented 8 years ago

Although it seems no one ever did figure out how to trigger a Travis rebuild, this branch still applies cleanly and is passing the since-released Node 0.10 and 0.11 builds.

Are you still interested in this fix? It's still a hack, but a relatively isolated one, and I don't think node-pw is ever going to get updated.

joewreschnig commented 7 years ago

I'm not using vault anymore. I'll leave the pw PR open since it's the "right" fix, but don't care about this hack.