search

jcoglan / vault

Generates safe passwords so you never need to remember them
https://getvau.lt
471 stars 64 forks source link

span vs. input for generated password #4

Closed panesofglass closed 12 years ago

panesofglass commented 12 years ago

The web version is great, but I had trouble selecting the generated password to copy/paste when on my WP7 mobile device. This may or may not be a problem for other devices. A simple fix would be to replace the generated password's input field with a span.

jcoglan commented 12 years ago

I used an input precisely because it makes selection easier. What happens when you try to select it, I'm afraid I'm not familiar with WP7 at all.

panesofglass commented 12 years ago

My cursor just gets placed in the input field. I can't select anything at all. I'll see if I can find a way to select it. Otherwise, would having both a span and input be problematic?

jcoglan commented 12 years ago

Not knowing how selection works on WP7, I'm not sure how to solve this. On the desktop, and input means that CTRL-A within the input selects only the input's contents, as opposed to the whole page. On Android you just tap and hold the input, and its contents are selected. I would expect your browser to provide a means of doing this, but if it doesn't feel free to experiment and submit a pull request if you find a solution.

panesofglass commented 12 years ago

I tried several more times and was able to select the text. Subsequent attempts are hit-or-miss, so I'll chalk this up to a poor UX on the part of the WP7 and close the issue.