search

jcohenadad / GBM8378

Polytechnique Montreal course "Principes d'imagerie biomédicales"
https://www.polymtl.ca/etudes/cours/principes-dimagerie-biomedicale
MIT License
2 stars 5 forks source link

Fix binder badge #30

Closed po09i closed 1 year ago

po09i commented 2 years ago

The binder badge has been broken. Binder seems to have switched some default behaviour at the beginning of 2022 which coincides with then we observed the problem. This thread discusses it in more detail. The fix specifies in the path to use the old behaviour.

po09i commented 2 years ago

@sandrinebedard Can you test if the badge now works for you

sandrinebedard commented 2 years ago

It loaded in 2 seconds for me!

image

jcohenadad commented 2 years ago

ok let me try again

jcohenadad commented 2 years ago

It loaded in 2 seconds for me!

I'm a bit suspicious about the 2 seconds because conda needs to be installed, and then all deps need to be downloaded and installed. Even locally it takes at least 30s or more, no? Is it possible that it was using a cached version of MyBinder in your browser?

sandrinebedard commented 2 years ago

It loaded in 2 seconds for me!

I'm a bit suspicious about the 2 seconds because conda needs to be installed, and then all deps need to be downloaded and installed. Even locally it takes at least 30s or more, no? Is it possible that it was using a cached version of MyBinder in your browser?

That's what I am thinking too! But I never managed to load it before, that's why I am also suspicious ... I am testing it in a private browsing tab too.

jcohenadad commented 2 years ago

Another try, resulting in an error after 25 minutes: image

(also in private browsing tab).

I suggest asking other students in the lab to run it and get feedback.

po09i commented 2 years ago

I also ran into problems... (It hung there for 15 minutes)

Screen Shot 2022-12-01 at 12 01 15 PM

sandrinebedard commented 2 years ago

on the private browsing tab, it took 15 mins to load and works now!

gaspardcereza commented 2 years ago

I tried it in incognito mode and it only took about 10s. I executed some cells in lab 3 and everything behaves as expected. Maybe binder just got very very good at creating environments quickly, but that would not explain why it fails on your end...

From what I recall, Binder does not always use the same hosting service, maybe that's part of the explanation.

po09i commented 2 years ago

I tried a few things, notably installing jupiter lab instead. It seems more reliable now.. I was previously able to replicate Julien's error and now it seems to work pretty reliably when building from scratch, in private windows and in non private windows. When it does not work, I just reload the page and it usually works the 2nd time.

po09i commented 2 years ago

Binder seems to have issues when using an adblocker, we might want to suggest to turn it off in the README.

jcohenadad commented 2 years ago

we're making progress 🎉 it worked for me (4min of loading):

image

i'm just afraid their servers are unreliable, but who knows... 🤷