jcoleman / JCNotificationBannerPresenter

A library for generic presentation of "banners" (e.g. to present a push notification) from anywhere inside an iOS app.
MIT License
199 stars 46 forks source link

Banner Timeout Implemented #17

Closed brokaw closed 11 years ago

brokaw commented 11 years ago

Adds a timeout value to JCNotificationBanner:

We wanted some of the notifications to require user interaction to dismiss, and some to automatically dismiss after some timeout period. This is an overview of the changes we made to implement that.

Net effect is that the code should be backward compatible, but you can set a timeout on specific notification if you want to.

In our tree this is applied on top of the previous pull request (#16), but the changes should be independent.

jcoleman commented 11 years ago

All right, I like the idea here. I've added several inline comments regarding a few tweaks and some code style consistency issues, but other than that, looks good.

Could you also update the README to document these options?

jcoleman commented 11 years ago

Thanks for contributing!