Fix iOS7 and Smoke notifications when call / hotspot bar displayed

jcoleman / JCNotificationBannerPresenter

A library for generic presentation of "banners" (e.g. to present a push notification) from anywhere inside an iOS app.

MIT License

198 stars 46 forks source link

Fix iOS7 and Smoke notifications when call / hotspot bar displayed #28

Open mrkhingston opened 9 years ago

mrkhingston commented 9 years ago

I don't have access to any iOS 6 device / simulator so I haven't been able to test this there but I can confirm that on iOS 7 & 8 this fixes the banner so that it appears from the top of the screen.

I didn't know how to fix the rotating iOS 6 style banner presenter.

I attempted to test this in portrait and landscape orientations, but even without this change, the demo project is very broken for me when run in landscape orientation. All of the types of notifications display off screen.

mrkhingston commented 9 years ago

Just a follow up - I got landscape mode to work in the demo app by also taking the 'no status bar' fix from the PR created by @apiech

So I can now say that: yes - the fix works in both portrait and landscape mode on iOS 7 and 8.