search

jcoliz / LogoSlideMaker

Logo Slide Maker is a Windows Desktop application to build, preview, and generate PowerPoint presentations containing logos with text.
https://apps.microsoft.com/detail/9p09gnvhnl72
MIT License
0 stars 0 forks source link

[Package] Consider running in an app container #27

Closed jcoliz closed 4 months ago

jcoliz commented 4 months ago

May be necessary to pass store certification.

In simplest form, app probably needs broadFileSystemAccess. This is so that user isn't constrained on where to store their files. User can get access to their TOML file using the picker, but we need access from that folder downward. Perhaps could use StorageItemAccessList to accomplish this.

Also it's currently storing logs in system temp directory. Probably wouldn't be too hard to move those to ApplicationData.TemporaryFolder

jcoliz commented 4 months ago

How will we open the folder for logs? Currently, I am using Process.Start("explorer.exe", MainViewModel.LogsFolder);, which feels like something App Container won't like.

jcoliz commented 4 months ago

Docs: https://learn.microsoft.com/en-us/windows/msix/msix-container

jcoliz commented 4 months ago

Reading more dotnet threads, it looks like fulltrust may be totally allowed now. Perhaps may not be needed.

jcoliz commented 4 months ago

Experimenting with this now. Fails with:

DEP0700: Registration of the app failed. [0x80080204] error 0x80080204: App manifest validation error: Line 26, Column 6, Reason: The element specified requires "runFullTrust" capability.

I was thinking it was complaining about:

    <TargetDeviceFamily Name="Windows.Desktop" MinVersion="10.0.17763.0" MaxVersionTested="10.0.19041.0" />

However, removing that line just changes the line# of the error. Will wait to see if this is really needed before continuing on this endeavor.

jcoliz commented 4 months ago

Was able to pass store certification without it. No need for app container.