jcollard / elm-mode

Elm mode for emacs
GNU General Public License v3.0
376 stars 67 forks source link

Interpret ansi-colors in fomatter's error message #100

Closed juanedi closed 7 years ago

juanedi commented 7 years ago

Current versions of elm-format use ANSI codes to display colored output.

Before this change, the raw output of elm-format was being displayed to the user using the message function, which resulted in escape sequences being shown:

screen shot 2017-04-25 at 11 36 08

This commit uses ansi-color to interpret color codes when reading the output of elm-format, so that when the error message is displayed we only show meaningful text:

screen shot 2017-04-25 at 11 41 15

This is related to #98. Fixes the problem for the formatter output but not for the compilation buffer (since we use different ways of displaying output for each case)

purcell commented 7 years ago

Updated with the above feedback and applied in 2df7506 - thanks!