search

jcollard / elm-mode

Elm mode for emacs
GNU General Public License v3.0
373 stars 67 forks source link

(0.19) Elm reactor does not recognize flag `-p` #144

Closed benreyn closed 5 years ago

benreyn commented 5 years ago

When running elm reactor in elm 0.19 the *elm-reactor* buffer displays this message...

I do not recognize this flag:

    -p

Maybe you want --port=<port> instead?

Process elm-reactor exited abnormally with code 1

Apparently in elm 0.19 the -p flag is deprecated and now expects the command to be run as. elm reactor --port=8080 it also appears as though the -a flag is now deprecated. I was going to just submit a patch but given that there are alot of changes floating around regarding elm 0.19 and #141 is open, I figured I would open an issue to discuss fist.

purcell commented 5 years ago

Yeah, as noted here I think this problem can currently be configured away, and #141 would cover the auto-configuration (or updated defaults) for this later. As such, I don't think we need to keep this issue open separately.

benreyn commented 5 years ago

Oh, I see! I need to set elm-reactor-arguments as well! Thanks @purcell !