search

jcollard / elm-mode

Elm mode for emacs
GNU General Public License v3.0
373 stars 67 forks source link

Remove reliance on reformatter #178

Closed theothornhill closed 3 years ago

theothornhill commented 3 years ago

Hi again!

I'm wondering - making the assumption that most elm/emacs users are using an lsp-client - maybe it is time to remove the reformatter code? I know the package is yours, but it feels like installing packages when the same functionality is supplied by the de facto tooling shouldn't be necessary.

I also know it is working code, and as such may break some users workflow, but likely they already have installed the alternative already.

I'm putting this up for discussion before making a PR to get your opinion on this. What do you think?

purcell commented 3 years ago

Nope, leaving it for now, thanks. It's reasonable to provide basic integration with core community tools.

purcell commented 3 years ago

as such may break some users workflow

(I am one such user. 😄 )

coddeys commented 3 years ago

I am one such user too. smile