jcollard / elm-mode

Elm mode for emacs
GNU General Public License v3.0
373 stars 67 forks source link

indentation mode inserts tabs, but elm compiler does not accept tabs #180

Closed dandrake closed 2 years ago

dandrake commented 2 years ago

I've enabled Elm indent mode with elm-indent-mode, but it's using tabs for indentation, and when I compile, I get:

I ran into a tab, but tabs are not allowed in Elm files.

I'm using Elm 0.19.1.

If the compiler truly refuses to accept tabs, shouldn't elm-mode avoid using them?

Thanks.

bhyland commented 2 years ago

I've had the same problem. Are you using the nightly emacs builds? I am, and for some reason it's changed the behaviour of indent-tabs-mode:

It used to work such that declaring (indent-tabs-mode nil) would turn off indent-tabs-mode. However a recent change only turns it off if it is set to a negative number, so nil now turns it on.

I had a call to indent-tabs-mode in my .emacs which started to turn it on automatically. I modified that, and now everything's working fine again.

-- Brendan Hyland @.***

On Fri, Dec 24, 2021, at 11:53 AM, Dan Drake wrote:

I've enabled Elm indent mode with elm-indent-mode, but it's using tabs for indentation, and when I compile, I get:

I ran into a tab, but tabs are not allowed in Elm files. I'm using Elm 0.19.1.

If the compiler truly refuses to accept tabs, shouldn't elm-mode avoid using them?

Thanks.

— Reply to this email directly, view it on GitHub https://github.com/jcollard/elm-mode/issues/180, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANXTETNU6ETAW6BNQ53M6TUSS6SFANCNFSM5KW6Y2RQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.***>

dandrake commented 2 years ago

Ah, that did the trick -- it was set to t in my emacs, and toggling it off via Customize (which sets it to nil for me) did the trick. (I'm using emacs 27.1.)

On Fri, Dec 24, 2021 at 11:24 AM bhyland @.***> wrote:

I've had the same problem. Are you using the nightly emacs builds? I am, and for some reason it's changed the behaviour of indent-tabs-mode:

It used to work such that declaring (indent-tabs-mode nil) would turn off indent-tabs-mode. However a recent change only turns it off if it is set to a negative number, so nil now turns it on.

I had a call to indent-tabs-mode in my .emacs which started to turn it on automatically. I modified that, and now everything's working fine again.

-- Brendan Hyland @.***

On Fri, Dec 24, 2021, at 11:53 AM, Dan Drake wrote:

I've enabled Elm indent mode with elm-indent-mode, but it's using tabs for indentation, and when I compile, I get:

I ran into a tab, but tabs are not allowed in Elm files. I'm using Elm 0.19.1.

If the compiler truly refuses to accept tabs, shouldn't elm-mode avoid using them?

Thanks.

— Reply to this email directly, view it on GitHub < https://github.com/jcollard/elm-mode/issues/180>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AANXTETNU6ETAW6BNQ53M6TUSS6SFANCNFSM5KW6Y2RQ . Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/jcollard/elm-mode/issues/180#issuecomment-1000920001, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJXE5Y3V5WQR6NJR3VRMY3USTCGJANCNFSM5KW6Y2RQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- Ceci n'est pas une .signature.

purcell commented 2 years ago

Fixed by default in 02eb8dea838fa8fc22915fb7c7d0ed8ff2af634a