jcollard / elm-mode

Elm mode for emacs
GNU General Public License v3.0
373 stars 67 forks source link

Compilation errors on Emacs 28.1 #186

Closed sirgazil closed 2 years ago

sirgazil commented 2 years ago

Steps to reproduce

In Emacs:

  1. M-x package-install
  2. elm-mode

Expected result

☑ The package is installed without errors
elm-mode is activated whenever I open a .elm file?

Unexpected result

☒ The package is installed, but there are errors (see Errors section below)
elm-mode is not activated when I open a .elm file

Package information

Package elm-mode is installed.

     Status: Installed in ‘elm-mode-0.21.0/’ (unsigned). Delete
    Version: 0.21.0
     Commit: 5df694e307cf8fa5a3555d800984aa4ebb40664f
    Summary: Major mode for Elm
   Requires: f-0.17, s-1.7.0, emacs-25.1, dash-2.13.0, reformatter-0.3
    Website: https://github.com/jcollard/elm-mode
 Maintainer: Joseph Collard
     Author: Joseph Collard
Other versions: 0.21.0 (melpa-stable).

Errors

In Compile-Log buffer:

Leaving directory ‘/home/yo/.config/emacs/elpa/elm-mode-0.21.0’

Compiling file /home/yo/.config/emacs/elpa/elm-mode-0.21.0/elm-font-lock.el at Fri May 27 13:07:01 2022
Entering directory ‘/home/yo/.config/emacs/elpa/elm-mode-0.21.0/’
elm-font-lock.el:151:1: Warning: defconst
    `elm--regexp-multiline-list-comma-closing-brackets' docstring wider than
    80 characters

In elm--match-multiline-list-opening-bracket:
elm-font-lock.el:160:8: Warning: docstring wider than 80 characters

In elm--search-forward-closing-bracket:
elm-font-lock.el:181:8: Warning: docstring wider than 80 characters

Compiling file /home/yo/.config/emacs/elpa/elm-mode-0.21.0/elm-format.el at Fri May 27 13:07:01 2022
elm-format.el:58:3: Warning: Use keywords rather than deprecated positional
    arguments to `define-minor-mode'

Compiling file /home/yo/.config/emacs/elpa/elm-mode-0.21.0/elm-imenu.el at Fri May 27 13:07:01 2022

Compiling file /home/yo/.config/emacs/elpa/elm-mode-0.21.0/elm-indent.el at Fri May 27 13:07:01 2022

In elm-indent-next-symbol-safe:
elm-indent.el:258:8: Warning: docstring wider than 80 characters
elm-indent.el:1207:1: Error: Wrong number of arguments: (3 . 4), 2

Compiling file /home/yo/.config/emacs/elpa/elm-mode-0.21.0/elm-interactive.el at Fri May 27 13:07:01 2022

In elm-compile--command:
elm-interactive.el:374:8: Warning: docstring wider than 80 characters

In elm-compile-clean-imports:
elm-interactive.el:456:8: Warning: docstring wider than 80 characters

In elm-compile-add-annotations:
elm-interactive.el:513:8: Warning: docstring wider than 80 characters

In elm-company--make-candidate:
elm-interactive.el:995:8: Warning: docstring wider than 80 characters

In elm-oracle--catalogue-with-local-names:
elm-interactive.el:1068:8: Warning: docstring wider than 80 characters

Compiling file /home/yo/.config/emacs/elpa/elm-mode-0.21.0/elm-mode.el at Fri May 27 13:07:01 2022
elm-mode.el:36:1: Error: Wrong number of arguments: (3 . 4), 2

Compiling file /home/yo/.config/emacs/elpa/elm-mode-0.21.0/elm-tags.el at Fri May 27 13:07:01 2022
elm-tags.el:33:1: Warning: custom-declare-variable
    `elm-tags-exclude-elm-stuff' docstring wider than 80 characters

Compiling file /home/yo/.config/emacs/elpa/elm-mode-0.21.0/elm-util.el at Fri May 27 13:07:01 2022

In end of data:
elm-util.el:70:22: Warning: the function ‘haskell-ds-forward-decl’ is not
    known to be defined.
elm-util.el:64:22: Warning: the function ‘haskell-ds-backward-decl’ is not
    known to be defined.

In Messages buffer:

Install package ‘elm-mode-0.21.0’? (y or n) y
Saving file /home/yo/.config/emacs/init.el...
Wrote /home/yo/.config/emacs/init.el
Contacting host: stable.melpa.org:443 [2 times]
Parsing tar file...done
Extracting...done
  INFO     Scraping files for elm-mode-autoloads.el... 
Generating autoloads for elm-font-lock.el...done
Generating autoloads for elm-format.el...done
Generating autoloads for elm-imenu.el...done
Generating autoloads for elm-indent.el...done
Generating autoloads for elm-interactive.el...done
Generating autoloads for elm-mode-pkg.el...done
Generating autoloads for elm-mode.el...done
Generating autoloads for elm-tags.el...done
Generating autoloads for elm-util.el...done
  INFO     Scraping files for elm-mode-autoloads.el...done
Wrote /home/yo/.config/emacs/elpa/elm-mode-0.21.0/elm-mode-autoloads.el [2 times]
Eager macro-expansion failure: (wrong-number-of-arguments (3 . 4) 2) [2 times]
Error loading autoloads: (wrong-number-of-arguments (3 . 4) 2)
Checking /home/yo/.config/emacs/elpa/elm-mode-0.21.0...
Wrote /home/yo/.config/emacs/elpa/elm-mode-0.21.0/elm-font-lock.elc
Checking /home/yo/.config/emacs/elpa/elm-mode-0.21.0...
Wrote /home/yo/.config/emacs/elpa/elm-mode-0.21.0/elm-format.elc
Checking /home/yo/.config/emacs/elpa/elm-mode-0.21.0...
Wrote /home/yo/.config/emacs/elpa/elm-mode-0.21.0/elm-imenu.elc
Checking /home/yo/.config/emacs/elpa/elm-mode-0.21.0... [2 times]
Wrote /home/yo/.config/emacs/elpa/elm-mode-0.21.0/elm-interactive.elc
Checking /home/yo/.config/emacs/elpa/elm-mode-0.21.0... [3 times]
Eager macro-expansion failure: (wrong-number-of-arguments (3 . 4) 2) [2 times]
Checking /home/yo/.config/emacs/elpa/elm-mode-0.21.0...
Wrote /home/yo/.config/emacs/elpa/elm-mode-0.21.0/elm-tags.elc
Checking /home/yo/.config/emacs/elpa/elm-mode-0.21.0...
Wrote /home/yo/.config/emacs/elpa/elm-mode-0.21.0/elm-util.elc
Checking /home/yo/.config/emacs/elpa/elm-mode-0.21.0...
Done (Total of 6 files compiled, 2 failed, 2 skipped)
Eager macro-expansion failure: (wrong-number-of-arguments (3 . 4) 2) [2 times]
Error loading autoloads: (wrong-number-of-arguments (3 . 4) 2)
Package ‘elm-mode’ installed.
kraai commented 2 years ago

I think this is fixed on master by 688d20b7cd0220af334d618608d8dfb0df250c69 and 714a3cebb3fe7e82a294d046d7fa7978e9ca8945 and that a new version needs to be released to fix it in melpa-stable.

purcell commented 2 years ago

I pushed a fresh tag (v0.22.0) which should resolve that

sirgazil commented 2 years ago

Great! I just tried it and it works. Thank you very much :)