jcollard / elm-mode

Elm mode for emacs
GNU General Public License v3.0
373 stars 67 forks source link

Change order of args for `elm-project-find-function`. #188

Closed akoppela closed 1 year ago

akoppela commented 1 year ago

It seems that order of ags for locate-dominating-file function should be reversed. According to docs on Emacs 28.2.

akoppela commented 1 year ago

Signature (locate-dominating-file FILE NAME)

Documentation Starting at FILE, look up directory hierarchy for directory containing NAME.

FILE can be a file or a directory. If it's a file, its directory will serve as the starting point for searching the hierarchy of directories. Stop at the first parent directory containing a file NAME, and return the directory. Return nil if not found. Instead of a string, NAME can also be a predicate taking one argument (a directory) and returning a non-nil value if that directory is the one for which we're looking. The predicate will be called with every file/directory the function needs to examine, starting with FILE.

Other relevant functions are documented in the file group.

purcell commented 1 year ago

Indeed, thanks. Merging despite somewhat broken CI, since this wasn't the change that caused it.

akoppela commented 1 year ago

Thanks for the function, works great with Eglot.