jcollard / elm-mode

Elm mode for emacs
GNU General Public License v3.0
375 stars 67 forks source link

implemented the todo for single comments, strings no longer escape the c... #3

Closed m4b closed 10 years ago

m4b commented 10 years ago

...omment face (however, an open string quote with no closing quote will stringify the rest of the code until it is closed, don't think there is a way to get around this, since strings are at the syntax level of font highlighting); changed some of the regexps to use [:space:] character classes; changed the formatting of the lists and symbols to make it compatible with the regexps, in particular the make-local-variable line --- eval of font-lock-defaults should return a list with regexps and values, etc., before it returned the variable elm-font-lock-highlighting, not sure how it was font-locking; emacs lisp is weird

jcollard commented 10 years ago

These changes look pretty good. I really need to find a way for -- to be at the syntax level. I just don't understand fully how this works yet.

m4b commented 10 years ago

Yea, unfortunately like you said, it looks the syntax highlighting for comments doesn't work that well?

We (you) (someone) could try hacking the syntax table, and adding entries that start with --, but end with a \n ... ? not sure if that would work.