search

jcollard / elm-mode

Elm mode for emacs
GNU General Public License v3.0
375 stars 67 forks source link

Autocomplete error #89

Closed hakonrossebo closed 7 years ago

hakonrossebo commented 7 years ago

I've created a spacemacs issue here - https://github.com/syl20bnr/spacemacs/issues/7932 Not sure if this is related to Spacemacs or elm-mode. As described in the issue, autocomplete works as expected after using the "complete-symbol" C-M-i command.

bmag commented 7 years ago

FYI make-process was introduced in Emacs 25.1, and you're using it here: https://github.com/jcollard/elm-mode/blob/529c20acb9efda756b69e267d73d33c66fa08293/elm-interactive.el#L886

Bogdanp commented 7 years ago

Thanks @bmag, I didn't realize make-process was introduced that recently. I've made the completion function degrade gracefully (to a sync call) when make-process is not available. I believe that'll fix the issue.

hakonrossebo commented 7 years ago

Thanks - works fine now :100:

Bogdanp commented 7 years ago

@hakonrossebo You're welcome. I'd still suggest upgrading to 25.1 since there is a large performance difference between the sync and async completion implementations.