jcommelin / queueboard

Mathlib4 review and triage dashboard
https://jcommelin.github.io/queueboard/
Apache License 2.0
3 stars 4 forks source link

Tracking further kinds of PRs #11

Closed grunweg closed 2 months ago

grunweg commented 4 months ago

What do you think about including a few more categories:

  1. PRs looking for an owner: labelled with please-adopt or help-wanted

  2. PRs stalled on a decision: not sure how to define this; awaiting-zulip and no activity in a while could be one way. (I don't think we're good tagging such PRs currently --- but if these are tracked specially, that could change. If I had a way to surface "this is blocked on a decision" PRs more prominently, I would certainly use it more.)

  3. PRs awaiting merge: all PRs which are just blocked on a merge --- CI passes, not WIP or blocked, but a merge conflict

  4. I think it could also be interesting to have a list of "PRs falling through the cracks", whose status we cannot determine otherwise. A first approximation could be this list of PRs which

    • are not blocked on another PR
    • not awaiting-author, awaiting-zulip or awaiting-CI
    • are not marked WIP or draft
    • are not ready-to-merge or delegated
    • fail CI (merge conflicts can be tracked separately)
grunweg commented 3 months ago

17 implements items (1) and (3). The others would not be difficult either, but let's wait until this board is actually used to decide so.

grunweg commented 3 months ago

39 implements item (2), by simply following the "needs-decision" label

grunweg commented 2 months ago

In light of the new statistics section (and automatic classification of PRs according to their state), item (4) is essentially obsolete. The only step possibly worth doing is showing which PRs fit into a certain category: this should be easy to do, and can be done if there is a need later.