search

jcommelin / queueboard

Mathlib4 review and triage dashboard
https://jcommelin.github.io/queueboard/
Apache License 2.0
3 stars 4 forks source link

Take CI status into account better #57

Closed grunweg closed 1 month ago

grunweg commented 1 month ago

Right now, the PR statistics and the on the queue page do not take each PR's CI status into account. For better precision, it would be nice to fix this. I can see two ways to do so:

  1. add another query in dashboard.sh, for all PRs with passing CI, and use that to cross-reference
  2. somehow, also query the CI status as part of the data retrieved in dashboard.sh, and read that instead.

Any solution found here could also apply to the base branch, if desired.

grunweg commented 1 month ago

The "on the queue page" uses the PR status now, when possible. (It reads from aggregate_pr_data.json, which is in turn distilled from the PR data in data.) Using the same data for the PR statistics is best done once all missing PR's data is backfilled. Currently, there are about a hundred PRs missing (so this will hopefully be done in a day).

Even in that case, handling the case of "missing data" gracefully (and treating as failing CI) seems prudent.

grunweg commented 1 month ago

This is now fixed: there are about four PRs with missing data; all relevant places have a fall-back for this case.