Added chinese language support old

jcoppieters / cody

Javascript Content Management System running on Node.js

howest.cody-cms.org

MIT License

678 stars 197 forks source link

Added chinese language support old #30

Closed linksgo2011 closed 9 years ago

linksgo2011 commented 9 years ago

(Add a language pack, default to en, users need to manually modify the default language, then increase when creating select language.

linksgo2011 commented 9 years ago

@ticup I submit some code, please check if wrong, increased international support, and a Chinese language pack

ticup commented 9 years ago

@linksgo2011 : Looks great! I was just wondering if there is any way we could manage Cody's i18n in cody itself...

@jcoppieters If I'm correct, the cms interface is already written in cody itself, no? So we could easily insert linksgo's translations into the db?

Of course, this would also mean a more difficult upgrade transition, because people would need to update their databases, whereas with the json solution they can just update cody and it will work.

linksgo2011 commented 9 years ago

@ticup I have dealt with all the template on static text above, using the __ () package, so that we can convenient to internationalization of template, because users can modify the content of the database, so we only need to change the database content in the next version

jcoppieters commented 9 years ago

Let's try to merge this! I think the json locale files are a good choice.

but before we do:

lin, can you add the locale setting to the config.json / cody.config and pick it up in doc/empty/index.js ? same way as we do the db, user, pw, etc...
I'll make a Dutch file as second example

Questions:

don't we need a "en" locale file and make the labels shorter?
if we now correct a label in the program, we probably have to change all the locale files, no?

Johan.

linksgo2011 commented 9 years ago

jcoppieters

Because I am not familiar with the project, you may submit a change for me. I think whether can choose when creating a language? Make notes in the document, using the corresponding language themselves add language file

lin

ticup commented 9 years ago

@linksgo2011: Ok, here is what I suggest:

Redo the pull request, but now instead of doing a pull request from linksgo:master to jcoppieters:master, do a pull request from linksgo:master to the jcoppieters:i18n branch (I created it).

Like this I can just accept the pull request and then easily incorporate the suggested changes by @jcoppieters and then finally merge them into the master branch!

Thanks a bunch!!

linksgo2011 commented 9 years ago

@ticup Ok

ticup commented 9 years ago

See https://github.com/jcoppieters/cody/pull/31

jcoppieters commented 9 years ago

Wow thanks man!

Johan.

Sent from my iPad.

On 25 Aug 2015, at 21:14, Tim Coppieters notifications@github.com wrote:

Closed #30.

— Reply to this email directly or view it on GitHub.