[joss review] Update Makefiles

jcorbino / mole

Mimetic Operators Library Enhanced

GNU General Public License v3.0

25 stars 19 forks source link

[joss review] Update Makefiles #14

Closed victorapm closed 4 months ago

victorapm commented 5 months ago

Hi @jcorbino, kudos on this cool package!

Regarding https://github.com/openjournals/joss-reviews/issues/6288, In the process of going over the installation procedure, I implemented a few changes to the Makefiles to improve user experience:

Show an error if ARMA is not defined
Allow usage of an external SuperLU installation with SUPERLU=PATH_GOES_HERE make
Add an option for a debug build with make DEBUG=1

Hope this is useful to you

jcorbino commented 4 months ago

Hello @victorapm - Sorry for the late reply. I had to relocate to Oregon this past month, and it was just now that I had the time to sit down and take care of the library. I saw your changes, thanks for proposing them. I'll proceed with the approval.

Thank you for the kind words!

victorapm commented 4 months ago

Glad this was helpful. Thanks!