search

jcoreio / crater

Meteor/Webpack/React SSR app skeleton that runs your app code outside of Meteor Isobuild
ISC License
82 stars 10 forks source link

issue#140 .nvmrc to autoswitch terminal from node7 to node6 #145

Closed Falieson closed 7 years ago

Falieson commented 7 years ago

Automatically switch from node7/yarn to node6 when entering the crater directory. Will follow up this MR to update the Readme.md once https://github.com/jcoreio/crater/pull/142 is merged. https://github.com/creationix/nvm#calling-nvm-use-automatically-in-a-directory-with-a-nvmrc-file

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 94.932% when pulling aea48ef6ecc0146852bd4efe8503933e070cb607 on Falieson:issue140_nvmrc into 829da546457ed74ba2ae5bd0594c3a63d69367eb on jcoreio:master.

jedwards1211 commented 7 years ago

As I mentioned in another issue, some users may want to run Crater with node 4 or 5, but this would practically force them to run it with 6.10. Let's keep .nvmrc out of this repo, of course you can still have it and gitignore it in your own working copy. I'll check if I can add engines to package.json though to prevent it from being run with node 7+

jedwards1211 commented 7 years ago

Hmmm, engines doesn't work. I'll just make my scripts warn if they detect node 7+ I guess

jedwards1211 commented 7 years ago

I need to merge the webpack2 stuff into master...there's a weird coverage decrease issue that I had intended to figure out first...

Falieson commented 7 years ago

The other PR where we discuss and close this issue https://github.com/jcoreio/crater/pull/142