search

jcoreio / crater

Meteor/Webpack/React SSR app skeleton that runs your app code outside of Meteor Isobuild
ISC License
82 stars 10 forks source link

Manually calling React.PropTypes validation function on Html (Warning) #149

Open Falieson opened 7 years ago

Falieson commented 7 years ago

== STR

webpack server terminal receives output

Warning: You are manually calling a React.PropTypes validation function for the `__meteor_runtime_config__` prop on `Html`. This is deprecated and will throw in the standalone `prop-types` package. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.
Warning: You are manually calling a React.PropTypes validation function for the `store` prop on `Html`. This is deprecated and will throw in the standalone `prop-types` package. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.
Warning: You are manually calling a React.PropTypes validation function for the `title` prop on `Html`. This is deprecated and will throw in the standalone `prop-types` package. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.
Warning: You are manually calling a React.PropTypes validation function for the `assets` prop on `Html`. This is deprecated and will throw in the standalone `prop-types` package. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

@jedwards1211 I'll probably submit a PR for this in the next day or two

jedwards1211 commented 7 years ago

@Falieson yes, this is an unfortunate side effect of react-dom-stream. I guess they'll fix that when the churn around PropTypes dies down.

jedwards1211 commented 7 years ago

what does STR stand for by the way?

Falieson commented 7 years ago

STR = Steps To Reproduce

Thanks for letting me know its from a 3rdparty package and not something I can fix in the repo

jedwards1211 commented 7 years ago

I almost think I should get rid of react-dom-stream and just stick with react-dom for now. It's fairly experimental...in fact it uses a fork of React internally. Another downside of react-dom-stream is that if a React component throws an error in the middle of SSR, it's impossible to send a 500 status code because it already had to send 200 to start streaming the HTML.