styles/global/global.css not working

jcoreio / crater

Meteor/Webpack/React SSR app skeleton that runs your app code outside of Meteor Isobuild

ISC License

82 stars 10 forks source link

styles/global/global.css not working #152

Open Falieson opened 7 years ago

Falieson commented 7 years ago

Code: https://github.com/jcoreio/crater/compare/webpack2...Falieson:wp2_globalCSSloaders-broken

$ yarn test:dev

[phantomjs #0-0] 1 failing
[phantomjs #0-0] 1) dev mode serves up global css:
[phantomjs #0-0] expected '8px' to equal '0px'

Falieson commented 7 years ago

I saw that global CSS is in the webpack config - is global.css supposed to be accessed the same way other .css files? I suppose I made an assumption here that it was built as a final asset because of its title.

jedwards1211 commented 7 years ago

Oh, huh... I'll have to check what went wrong later. The global css is supposed to be just good old fashioned css to include on every route, whereas all other css files are configured to use css modules, and be imported for specific routes and components.

Falieson commented 7 years ago

That's exactly how I thought it was supposed to work! :-)