jcoreio / crater

Meteor/Webpack/React SSR app skeleton that runs your app code outside of Meteor Isobuild
ISC License
82 stars 10 forks source link

Fix prod.js pointing to wrong build script #52

Closed evelant closed 7 years ago

jedwards1211 commented 7 years ago

@fignuts prod.js is intended to point to build-meteor.js because it starts Webpack in watch mode for the client and server bundles after buildMeteor() and installMeteorDeps(). (It used to point to build.js before I made it use Webpack in watch mode.) Are you having any problems with the way it's working?

evelant commented 7 years ago

@jedwards1211 Yes, try to run it as is and you will get an error about missing 'index.js' in the build dir. Index.js is compiled to the build dir by by buildServer which is not called in this case.

jedwards1211 commented 7 years ago

Oh I see, yes, the integration tests aren't catching that. The best solution will just be to compile index.js to the build dir instead of running the entire build.js. I'll make the change tomorrow. Thanks!