jcorporation / myMPD

myMPD is a standalone and mobile friendly web mpd client with a tiny footprint and advanced features.
https://jcorporation.github.io/myMPD/
GNU General Public License v3.0
418 stars 65 forks source link

Show control row to add the first disc of a multi-disc album #1126

Closed ThecaTTony closed 1 year ago

ThecaTTony commented 1 year ago

myMPD version: 12.0.4-1

Describe the bug

In multi-disc albums, the control row for adding the first disc is not shown, but the control rows for adding the second, third and so on are shown.

To Reproduce

Steps to reproduce the behavior:

  1. Browse a multi-disc album
  2. There is no control row to add the first disk

Expected behavior

The same control row should be displayed to add only the first disc of an album.

Screenshots

Screenshot_2023-10-09-19-51-37-079_com vivaldi browser Screenshot_2023-10-09-19-51-50-165_com vivaldi browser Screenshot_2023-10-09-19-51-50-165_com vivaldi browser

Server plattform:

Client plattform:

jcorporation commented 1 year ago

I can not reproduce this behavior. In my environment the first disc is displayed. Please grab the response for the MYMPD_API_DATABASE_ALBUM_DETAIL call via the webdeveloper tools and post it here.

ThecaTTony commented 1 year ago

Hi, I just want to clarify that the songs of disc 1 of a multi-disc album are listed, what is missing is the control row for that disc, which is highlighted in red for disc 2 of the example album.

mympd_disc1_bug

curl --header "Content-Type: application/json" --request POST --data '{"jsonrpc":"2.0","id":0,"method":"MYMPD_API_DATABASE_ALBUM_DETAIL","params":{ "albumid":"e153d032664bf3ae82c1322d2cb4482780b0fec8","cols":["Artist", "AlbumArtist", "Album", "Title", "Disc", "Track"]}}' http://pilar.tux/api/default > album_detail.json

album_detail.json

jcorporation commented 1 year ago

Hi, I just want to clarify that the songs of disc 1 of a multi-disc album are listed, what is missing is the control row for that disc, which is highlighted in red for disc 2 of the example album.

We mean the same.

The discs tag in the response has the value 1. This is the reason, why the table does not start with a disc row. The discs are counted by the album cache creation process. Please force an update of the caches and check again. This issue can occur if the disc tag was not enabled at album cache creation time (a bug in former releases).

ThecaTTony commented 1 year ago

Thanks, just as you said, the forced cache update fixed it.

mympd_disc1_bug_fixed