jcorporation / myMPD

myMPD is a standalone and mobile friendly web mpd client with a tiny footprint and advanced features.
https://jcorporation.github.io/myMPD/
GNU General Public License v3.0
418 stars 65 forks source link

Cannot add tracks on queue #22

Closed Emilot closed 6 years ago

Emilot commented 6 years ago

Describe the bug There are three folders in mnt folder of archlinux filesystem. One is nas-samba, one is nas-nfs, last is usb-disk.

From fstab file i mount nas-samba folder to Music NAS environment(to my case is a windows home server) and share my music tracks to raspberry pi.

Everything work great until the new "Append queue" function. The strange here is that i can queue an .m3u file but not any track, even from the same folder. I cannot add any mp3, flac, etc track...

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Browse'
  2. Click on 'Filesystem'
  3. Scroll down to 'any mounted folder and try to add a track from the little "ADD" button on the right'
  4. No error. I click it, but nothing happens.

Expected behavior To be added to queue

Screenshots untitled-2

untitled-1

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

Emilot commented 6 years ago

Forgot to mention that in folder webradio everything is working fine with .pls files.

untitled-3

untitled-4

jcorporation commented 6 years ago

Thanks for your bug report. One additional question: What happens if you click on the row itself?

Emilot commented 6 years ago

Unfortunately it worked. With the latest master version 3.20. i cannot add anything to queue. I see the "Added" signal on the top right, but nothing in queue page :(

I press on the radio station title, not on the "+" icon...

untitled-5 untitled-6

jcorporation commented 6 years ago

Appears the added signal also on song files? Your queue page looks strange. On an empty queue, a empty message should appear. I pushed a moment ago some queue view fixes to master.

Emilot commented 6 years ago

Yes, the added signal appears on song files, too. Look at the first images.

Let me check with 3.2.0.1

Thank you for the instant support!

Emilot commented 6 years ago

New situation.

Now i can add song files, if i click on the title bar, but not from add icon "+" (like previous)

I cannot add a web radio file in any way(add "+" icon or click on bar title)

PS. Now there is a sign "Empty queue" in queue :)

jcorporation commented 6 years ago

Very strange, in my setup this works all without any error. Can you recompile it with mkdebug.sh and starting mympd manually. The debug output can be helpfull.

Emilot commented 6 years ago

Error...

/usr/bin/ld: cannot find -lasan

i guess i have to install a prerequisite...

jcorporation commented 6 years ago

right, libasan3. it should be in your distri repos

jcorporation commented 6 years ago

I added better error handling for the ajax requests. Can you try current master and give me feedback, if a error occurs?

Emilot commented 6 years ago

Unfortunately i cannot execute the mkdebug script. In Archlinux i have gcc and gcc-libs already installed but i keep getting the same error. I guess something is wrong with the enviroment. Debian uses /usr/bin and Archlinux /usr/lib, but it is out of my knowledge base in Linux :(

With the latest master:

New condition. When i press the "Add icon" on a music folder(or a subfolder), i can see the "Append queue", etc..signs. It didn't show anything until now and i can add a whole album! :)

But inside the folder(at music files i mean) the "Add icon" doesn't work. I can add them if i click on the title.

Still no webradio file(.pls) can be added at queue. Even if i click on the title.

jcorporation commented 6 years ago

To compile the debug version you need libasan3.

Inside the folder (music files):

Playlist files:

Emilot commented 6 years ago

libasan3 is included inside the gcc or the gcc-libs package. I have them both installed, but same error.

Inside the folder (music files):

untitled 3

If i click on the folder, everything working good. Pop up and i see the files in the queue list.

untitled-2

Playlist files:

untitled-1

I do not see the javascript console :(

jcorporation commented 6 years ago

You can find the javascript console in Firefox under Web Developer -> Web Console. It seems that these are javascript problems. You tried to clean your browser cache?

Emilot commented 6 years ago

Οκ!

This error appears on every page:

untitled-4

This is the error when i hit "Add icon" on a track file:

untitled-5

Cache cleaned(Today option, not everything). Same happens in Chrome.

jcorporation commented 6 years ago

I think I found the error, why the popup don't appear on a track file. The other javascript errors should by also fixed in current master

Emilot commented 6 years ago

Jcorp the minified files are updated? I cannot see any difference :(

Same errors in console.

jcorporation commented 6 years ago

now are the minfied files alos updated

Emilot commented 6 years ago

Jcorp you are doing a professional work with Mympd. I really love your work so far.

Thank you for everything!

Everything working fine :)

jcorporation commented 6 years ago

Many thanks. Then i'm closing this ugly bug now...