search

jcorporation / myMPD

myMPD is a standalone and mobile friendly web mpd client with a tiny footprint and advanced features.
https://jcorporation.github.io/myMPD/
GNU General Public License v3.0
419 stars 65 forks source link

Integrate ListenBrainz for scrobbling, etc #394

Closed jcorporation closed 2 years ago

jcorporation commented 3 years ago

Basic functions

Advanced

API documentation

https://listenbrainz.readthedocs.io/en/latest/users/api/

jcorporation commented 3 years ago

hate/love for MusicBrainz waits for recording id support in mpd: https://github.com/MusicPlayerDaemon/MPD/issues/1276

MUSICBRAINZ_TRACKID is the recording id

jcorporation commented 2 years ago

Love/hate and pin implementation waits for migration of api from msids to mbids: https://github.com/strawberrymusicplayer/strawberry/issues/788

MonkeyDo commented 2 years ago

Hello!

The love/hate and pin functionalities already work with MBIDs, if you have access to those.

We have yet to update the API documentation accordingly, but you can pass a recording_mbid key in the JSON body you send to the /feedback/recording-feedback endpoint

Similarly, the /pin endpoint will now accept a recording_mbid (without the need for a recording_msid at all)

Please let me know if you run into any issues!

jcorporation commented 2 years ago

Thanks for the hint, I will test it.

jcorporation commented 2 years ago

@MonkeyDo: I tested the recording-feedback api, now I get an error in the webinterface in the love/hate tab: https://tickets.metabrainz.org/browse/LB-1099

jcorporation commented 2 years ago

@MonkeyDo: tested the /pin endpoint: it works like a charm.

MonkeyDo commented 2 years ago

Glad to know pinning is working as expected!

Looks like we still have teething issues with the love/hate feature using MBIDs. We are working on a fix for the issue you had on the ListenBrainz website (the page doesn't crash anymore on beta.listenbrainz.org). However it was a symptom of a deeper issue, and you will see some items are missing data in that love/hate page until we fix it for good ("No metadata for…").

jcorporation commented 2 years ago

I can confirm that beta.listenbrainz.org is working. I think I scrobbled MBIDs as recording_msid in the past and that was the origin of the problem. I managed to remove all the invalid entries in the love/hate tabs with some api calls. Adding and removing love/hate does now work with MBIDs as you described. Thanks for your help!