search

jcorporation / myMPD

myMPD is a standalone and mobile friendly web mpd client with a tiny footprint and advanced features.
https://jcorporation.github.io/myMPD/
GNU General Public License v3.0
419 stars 65 forks source link

improved pagination with option "all" not working #405

Closed payback007 closed 3 years ago

payback007 commented 3 years ago

myMPD version: [6.10.0]

Thank you for the new update on myMPD!

Just installed the new version and tested new pagination. I got a failure setting the option "all". Up to max. number of 200 is working, setting also all the other available steps like 25, 50 or 100 per page. Setting of "all" resulting in this failure:

error_pagination_option_show_all
Emilot commented 3 years ago

Confirm the bug.

Here is the console error...

error

Can we have an "arrow" if someone want to go to the last page.

Thnx JC!

jcorporation commented 3 years ago

Can we have an "arrow" if someone want to go to the last page.

The number of total elements ist not defined in all query results from mpd. Where I know the number of total entries there should be already a last page arrow, e.g. in the queue view.

jcorporation commented 3 years ago

This are two bugs:

  1. settings don't allow max_elements_per_page to be zero
  2. UINT_MAX ist to large for the MPD search window

Both are fixed in v6.11.0 branch. Thanks for reporting.