jcorporation / myMPD

myMPD is a standalone and mobile friendly web mpd client with a tiny footprint and advanced features.
https://jcorporation.github.io/myMPD/
GNU General Public License v3.0
419 stars 65 forks source link

Lua scripting cannot be enabled in v8.0.0 git #508

Closed pgzh closed 3 years ago

pgzh commented 3 years ago

myMPD version: v8.0.0

Describe the bug

Feature lua scripting cannot be enabled in settings, showing "Lua is not compiled in" although lua-dev is present and found by build.sh

To Reproduce

Build mympd v8.0.0 from git and check Features tab in settings

Expected behavior

Ability to enable/disable lua scripting

Screenshots

Attached screenshot of Features tab in settings Screenshot at 2021-06-09 21-54-53

Server plattform (please complete the following information):

Client plattform (please complete the following information):

Debug logs (please attach if it can be usefull)

See https://github.com/jcorporation/myMPD/wiki/Debug

If the bug is not reproducible, please try disabling lua scripting and then try to re-enable it in the settings. I am not 100% sure it worked and stopped working after I disabled it once.

pgzh commented 3 years ago

Github won't allow uploading .conf or .tar files. Changed extension of mympd.conf to mympd.txt and created a gz archive with tar -czf instead of -cf. Probably the bug report template should be updated to consider this.

jcorporation commented 3 years ago

The mympd.conf US obsolet for v8.0.0. I rework the template after release, thanks for the hint.

jcorporation commented 3 years ago

If the bug is not reproducible, please try disabling lua scripting and then try to re-enable it in the settings. I am not 100% sure it worked and stopped working after I disabled it once.

This reproduced the issue.

pgzh commented 3 years ago

Thanks for taking care of this so quickly! I saw you removed the conf file and syscommands for 8.0.0 - what would be the preferred replacement for a shutdown syscommand in this branch? Shutting down my Pi via the webinterface is so convenient ;-)

jcorporation commented 3 years ago

Use a simple lua script to shutdown your Pi: https://github.com/jcorporation/myMPD/wiki/Scripting

pgzh commented 3 years ago

Lua scripting works like a charm, now I understand why you decided to drop the syscommands stuff - especially considering you're also making the config file obsolete. Thank you!