Can't add webradio to favorites

tsunulukai commented 2 years ago

myMPD version: 9.1.0 commit d6f68f81b5ae048b9525500c558326e590a1a8ab

Describe the bug

When trying to put a webradio in favorites, the following error appears and the radio doesn't get added to the webradio favorites view: ERROR: JavaScript error: TypeError: obj.StreamUridocument is undefined (https://nas/MyMPD/js/combined.js: 8)

Error happens the same with or without reverse proxy.

Screenshots

Additional Info Test build has been compiled and installed on Debian 11 bullseye amd64 as follows:

export WORKDIR="/root/builder"
export DISTROS="bullseye"
export TARGETS="amd64"
export DEBIAN_MIRROR="http://ftp.be.debian.org/debian"

cd myMPD
git pull
VERSION=$(grep CPACK_PACKAGE_VERSION_ CMakeLists.txt | cut -d\" -f2 | tr '\n' '.' | sed 's/\.$//')
./build.sh createassets
./build.sh sbuild_build
cd ..

dpkg -i builds/${DISTROS}-amd64/mympd_$VERSION-1_amd64.deb
systemctl daemon-reload
systemctl restart mympd

jcorporation commented 2 years ago

This should be already fixed with commit abf7af0bdcdf9f8003a8cf898070a2fce6409362

Please fetch current devel and try again.

tsunulukai commented 2 years ago

Indeed solved in devel... I was building from the v9.1.0 tag. Sorry for the false alarm

jcorporation / myMPD

Can't add webradio to favorites #664