jcorporation / myMPD

myMPD is a standalone and mobile friendly web mpd client with a tiny footprint and advanced features.
https://jcorporation.github.io/myMPD/
GNU General Public License v3.0
419 stars 65 forks source link

Search filter fields are not shown on mobile browsers #673

Closed stefanroellin closed 2 years ago

stefanroellin commented 2 years ago

myMPD version: 9.1.0

If I open myMPD in Chrome on an Android device, the filter fields 'Genre', 'Country' and 'Language' aren't populated. However, if I use Chrome on Ubuntu 21.10, these fields are populated and can be selected.

Steps to reproduce the behavior:

  1. Go to WebradioDB
  2. Click on filter
  3. Select country dropdown
  4. dropdown is empty

Expected behavior

I would expect that the country list is not empty while clicking on it.

Server plattform:

Client plattform:

Same behaviour observed with Samsung Internet Browser.

tsunulukai commented 2 years ago

I have the same issue in Chrome on Android, but it works fine using Firefox Nightly on Android

Chrome: Screenshot_20220203-155405

FireFox Nightly: Screenshot_20220203-155506

jcorporation commented 2 years ago

Seems to be a browser incompatibility with custom elements. Is the picture select e.g. for homeicons working? I have no android device to debug…

stefanroellin commented 2 years ago

Yes, the picture select is working (there is one option "Ligatur benutzen"):

image

Using the developer tools, one can see that the values are populated, but not shown:

image

jcorporation commented 2 years ago

Looking closer to your provided screenshots shows an invalid first option tag (incomplete value attribut ). Eventually this is the problem.

I can reproduce this issue with safari on my iPhone.

https://stackoverflow.com/questions/43077171/size-not-working-for-select-option-in-mobile

None of the suggested solutions are working. I think I must redesign this component and use a scrollable list-group instead of a select.

jcorporation commented 2 years ago

Should now fixed in devel. Please test and return feedback.

stefanroellin commented 2 years ago

I can confirm that the list is now also populated on a mobile browser and it is possible to select e.g. a country to filter the list.

However, the search field in the dropdown doesn't work anymore, neither on a desktop browser nor on a mobile browser.

On a desktop - 9.1.0: image

On a desktop - current devel version: image

jcorporation commented 2 years ago

Thanks for testing. Filtering the result should now work.

stefanroellin commented 2 years ago

The filtering now does work - thanks!

However I realized that a recent change has broken "Ligatur":

image

jcorporation commented 2 years ago

Should now also be fixed.

stefanroellin commented 2 years ago

Thanks for the fix.

Unfortunately since commit 39bda25205b8d625b08d1a573d595740bdfb7871 adding a webradio is partially broken, namely the icon isn't added anymore, even if it is added from the favourites:

image

and the resulting item on the Homepage:

image

Should I open a separate issue?

jcorporation commented 2 years ago

We can handle this in this issue, it seems to be a regression...

jcorporation commented 2 years ago

Should work now again.

stefanroellin commented 2 years ago

Now works again - thanks!