jcorporation / myMPD

myMPD is a standalone and mobile friendly web mpd client with a tiny footprint and advanced features.
https://jcorporation.github.io/myMPD/
GNU General Public License v3.0
418 stars 65 forks source link

4.4.0 browse music files does not work with disabled tags #68

Closed parkmino closed 5 years ago

parkmino commented 5 years ago

Describe the bug mympd 4.4.0 for ubuntu 18.04 does not browse music files. The package was downloaded from openSUSE Build Service. Clicking 'Browse' does not change the browser's url unlike 'Playback', 'Queue' and 'Search'.

To Reproduce Steps to reproduce the behavior:

  1. Click 'Browse'

Expected behavior Browse music folders and files.

Desktop (please complete the following information):

Additional context 4.2.1 version worked fine, but it is not available from the repository any more. Please let me know any check points on my side.

jcorporation commented 5 years ago

Are there any errors in the javascript console?

parkmino commented 5 years ago

If you mean terminal errors, no.

$ sudo mympd /etc/mympd/mympd.conf
Parsing config file: /etc/mympd/mympd.conf
Starting myMPD 4.4.0
Droping privileges to mympd
Document root: "/usr/share/mympd/htdocs"
Temp dir: "/var/lib/mympd/tmp"
Smartpls dir: "/var/lib/mympd/smartpls"
State dir: "/var/lib/mympd/state"
Reading states
Listening on http port 80
MPD Connecting to 127.0.0.1:6600
MPD connected.
MPD protocoll version: 0.21.0
Stickers are disabled, disabling smartplaylists
MPD supported tags: 
myMPD enabled tags:
jcorporation commented 5 years ago

I meant the javascript console in your browser (Firefox: Webdeveloper -> Webconsole).

But I see in your output that myMPD finds no enabled tags. That should be the problem.

1) Can you post your mpd.conf?

2) Please also set the log_level = "verbose" in mpd.conf and post the mpd.log after restarting myMPD

3) Please try the tagtypes command on your mpd manually:

telnet localhost 6600
tagtypes

Output should be similar to:

tagtype: Artist
tagtype: Album
tagtype: AlbumArtist
tagtype: Title
tagtype: Track
tagtype: Name
tagtype: Genre
tagtype: Date
tagtype: Composer
tagtype: Performer
OK
parkmino commented 5 years ago

Aha!

connected mympd.min.js:53:99
Error: Stored playlists are disabled mympd.min.js:142:300
[메시지에 대한 자세한 정보를 보거나 숨깁니다.] TypeError: app.apps[a].tabs[b].views[c] is undefined[더 알아보기] mympd.min.js:18:130
appGoto
http://localhost/js/mympd.min.js:18:130
appInit/<
http://localhost/js/mympd.min.js:34:398

1. In mpd.conf, metadata_to_use "none" Concerning tags, I do not want to enable any tags. ympd has no problem with browsing music directory.

  1. $ mpd --stdout --no-daemon --verbose /etc/mpd.conf
    $ telnet localhost 6600
    Trying 127.0.0.1...
    Connected to localhost.
    Escape character is '^]'.
    OK MPD 0.21.0
    tagtypes
    OK

If tags are mandatory, never mind this issue.

jcorporation commented 5 years ago

Enabled tags are mandatory for myMPD to work correctly. For minimum myMPD functionality, following tags must be enabled in mpd.conf metadata_to_use "AlbumArtist,Artist,Album,Title,Track"

You should also enable playlists: e.g. playlist_directory "/var/lib/mpd/playlists"

For details see https://github.com/jcorporation/myMPD/wiki/MPD-Configuration

jcorporation commented 5 years ago

I opened #69 to support mpd configurations with less features enabled.

Why you don't want to enable any tags?

parkmino commented 5 years ago

Disabling tags reduces overhead. It helps with huge library and reduces time to update library. For me, showing just folders and files are good enough like foobar2000 in windows. There has been no problem with any other mpd clients with tags disabled. I remember the the previous 4.2.1 version has worked fine.

parkmino commented 5 years ago

If browsing is disabled with tags disabled, I have no reason to use mympd. I think that you do not need to bother with #69.

jcorporation commented 5 years ago

Only the browse database tab would be disabled, because it is useless without tags. Browse filesystem would work furthermore as with ympd.

parkmino commented 5 years ago

OK, I got it and thanks for your support!

jcorporation commented 5 years ago

fixed in devel