jcorporation / myMPD

myMPD is a standalone and mobile friendly web mpd client with a tiny footprint and advanced features.
https://jcorporation.github.io/myMPD/
GNU General Public License v3.0
420 stars 66 forks source link

Validation of value for JSON path "$.params.codec" has failed #933

Closed pirateradiohack closed 1 year ago

pirateradiohack commented 1 year ago

While trying to save a webradio in my favorites the modal returned this error:

Validation of value for JSON path "$.params.codec" has failed

the codec is AAC+.

I thought this codec was supported by MPD, but I can't say I'm 100% certain. So if it's supported it means it's "just" a matter of validation. But if not supported then maybe improving the error message to communicate that would help.

jcorporation commented 1 year ago

This is a myMPD issue, not a myMPDos issue.

This seems to be a validation issue only. The codec field is only for display purposes. Leave out the + and should work. Will be fixed for the next version.

If you add manual webradio favorites, please consider adding it to webradioDB also: https://jcorporation.github.io/webradiodb/

pirateradiohack commented 1 year ago

Great, your workaround works! Thanks.

pirateradiohack commented 1 year ago

Regarding your mention of webradiodb, I am curious about the goal of this project.

I see in the README that it aims to be a curated list of radios for myMPD. Nice goal, but wouldn't that be achievable thanks to the great radio-browser.info project? I can see it is even integrated in myMPD.

I think I am missing something here, what would be the purpose of rebuilding another database instead of using and contributing to radio-browser.info?

jcorporation commented 1 year ago

The radio-browser.info project has a big quality problem, because of this: https://github.com/segler-alex/radiobrowser-api-rust/issues/49

If you want discuss this further, please open a new discussion.