search

jcpassy / mesa-h5

mesa hdf5 output se_support
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

Update to mesa 22.11.1 #13

Open rjfarmer opened 1 year ago

rjfarmer commented 1 year ago

As part of https://github.com/MESAHub/mesa/issues/523 I've made an updated version of the scripts for MESA's (current) newest release 22.11.1 here: https://github.com/rjfarmer/mesa-h5 on the master branch.

Not sure how you want to do a merge, whether in a separate folder or in the main directory. So that can be tweaked before I do a PR.

I have tested that things compile and run but I don't have any of the tools to check it's making a "correct" hdf5 file. So someone from nugrid would need to check that @HEBrinkman .

HEBrinkman commented 1 year ago

Dear Rob,

Thank you very much! I will check the files soon, and see if the output-files are correct compared to the previous version.

Cheers, Hannah

HEBrinkman commented 1 year ago

Dear Rob,

First of all, apologies for the delay on testing this, there were a lot of things that needed my attention. Unfortunately, I am not succeeding in generating the HDF5-files. I've added your mesa_hfd5*.inc routines into the src folder, and merged the run_star_extra-files, and added the hfd5_profile_columns.list to the work-directory. However, when running the ./mk-command, I get the following error: mesa_hdf5_routines.inc:54:0:

Fatal Error: Cannot open included file 'extra_history_cols.inc' compilation terminated.

The problem is that this extra_history_cols.inc is not in mesa-r22.11.1... Did I take the wrong mesa_hfd5*.inc? Or do I have to modify mesa-r22.11.1 as well?

Sorry for the mess... Hannah

rjfarmer commented 1 year ago

Those files are redundant now with newer mesa versions so the include statements can be deleted. I just pushed an update to fix things.

HEBrinkman commented 1 year ago

I've updated the files, and now everything seems to work. It is currently running, and I will check to contents of the h5-files later to see if it is correct.