search

jcpassy / mesa-h5

mesa hdf5 output se_support
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

same names in profiles and history #5

Open fherwig opened 6 years ago

fherwig commented 6 years ago

It is possible to select quantities which have the same names, such as logL to be names in profiles and history output, leading nugridse (and probably other tools) to get confused when trying to extract quantities.

Workaround: Find doubles in cattrs and dcols:

for otherthing in see.se.cattrs:
    [print(thing) for thing in see.se.dcols if otherthing in thing]

and make sure by hand that no name appears in both history_columns.list and profiles_columns.list.

However, the proper solution would be

  1. MESA should not use the same name for different things.
  2. Since we may not be able to change that immediately, mesa_h5 should check that same-named quantities can not be selected, stop the execution with a meaningful warning with clear instructions on what to do. Alternatively the names could be changed if the change_names="True" flag is set.
jcpassy commented 5 years ago

1- I agree 2- Don't you think that is should be handled by nugridse rather than by mesa_h5?