search

jcpsantiago / thearqivist

Backup Slack and create Confluence pages from your important conversations.
https://arqivist.app
MIT License
7 stars 1 forks source link

Track version in an external `version.txt|edn` file or make it part of aero config #23

Open jcpsantiago opened 1 year ago

jcpsantiago commented 1 year ago

Changing the version of the app in multiple places in code is lame, this should be configuration instead. Either track it in an external file, or make it part of aero configuration, in case we use it (not at the moment of writing).

jcpsantiago commented 1 year ago

@practicalli-john do you have an opinion about this? I really dislike the idea of typing a version number by hand in different places in the code. I think this should be configuration, ideally even though automatically e.g. via a github action upon an official release. But I would be ok with doing it by hand in a single place.

practicalli-johnny commented 1 year ago

I seem to be missing why the version of the app needs changing in multiple places in the code.

Does slack or atlassian require some version? I guess slack might want a version.

I would include a version in the Aero config as its already being passed around to handlers.

jcpsantiago commented 1 year ago

More like in the logs, README file, and docs. Keeping it in aero and then generating everything from it is an option.

practicalli-johnny commented 1 year ago

Oh, if it's docs, then I do search and replace with an editor

There should only be one place in the code that sets the version for all logs, the global context

Curious why the version is being changed so often already