search

jcpunk / puppet-efi

Facter fact for if system is booted in EFI mode
Apache License 2.0
2 stars 1 forks source link

Add the EFI partition to the facts #2

Open bschonec opened 2 years ago

bschonec commented 2 years ago

I think it would be nice to have a fact that would return the EFI boot partition as well.

When doing CIS/STIG remediation, one of the policies is to add "umask=0027,fmask=0077,uid=0,gid=0" to the options of the EFI boot partition in /etc/fstab. Having facter/Puppet figure out what partition is the EFI boot would be most helpful.

jcpunk commented 2 years ago

I've opened a bug upstream to get facter to "just have" the right values https://tickets.puppetlabs.com/projects/FACT/issues/FACT-3140

The only EFI-ESP mountpoints I'm seeing in the wild are /boot/efi and /efi. I'm wondering if it would be easier to explicitly check for those points rather than work around a fact.....

jcpunk commented 2 years ago

https://github.com/puppetlabs/facter/pull/2511

bschonec commented 2 years ago

Wow, that was fast. I could only hope to be able to write Puppet/Ruby code that quickly.

Thank you!