search

jcreedcmu / twelf-mac

Other
0 stars 1 forks source link

About box needs more licenses #20

Open agoode opened 3 months ago

agoode commented 3 months ago

There are a few licenses for used code that need to be shown in the about box as well as what's in the current box.

jcreedcmu commented 3 months ago

Agree. I welcome specific suggestions for the text you think is appropriate if you want to. Can summarize what's in LICENSE otherwise.

jcreedcmu commented 3 months ago

Please check if the current About text is satisfactory and suggest/merge changes if not. I'm not particularly attached to the wording, and very receptive to suggestions.

agoode commented 3 months ago

I think it won't fit on a screen and needs a scrolling text box.

You're supposed to include the full text of each license with the binary (see about:license on firefox). But if it's going to be in the about box, this is going to be super long. Maybe it just needs to go into a separate text file included with any binary distribution we make.

jcreedcmu commented 3 months ago

The "does it fit on a screen" is a good thought generally. I do want to make sure this works on a compact mac like the SE/30.

I think separate text file makes sense for meeting the obligation of the license being included with the binary distribution. My main goal for the about box is just that it fit the expected "texture" of an about box from the era. To my gut sense, a collection of copyright statements and attribution makes sense; not so much the full text of BSD or GPL or whatever. But if you have interesting examples, I'd love to see 'em.

jcreedcmu commented 3 months ago

Here is how it looks B&W on 512x342, after I decreased the image size and the font size: image

jcreedcmu commented 3 months ago

Is this issue resolved now, given the resolution of https://github.com/jcreedcmu/twelf-mac/issues/17 ?

agoode commented 3 months ago

Probably once we have a LICENSE file?

jcreedcmu commented 3 months ago

LICENSE has existed for a little while now.

jcreedcmu commented 3 months ago

If you want some automation of building a tarball that includes it alongside the binary, that would maybe be nice.