search

jcricket / gwt-syncproxy

Provides Synchronous and Asynchronous access to GWT-RPC servlets from Java and Android
http://www.blueesoteric.com/open-source/gwt-syncproxy
Apache License 2.0
23 stars 14 forks source link

add new method setBaseURL(String baseUrl, CookieManager cookiemanager) #47

Closed F4bwDP6a6W closed 9 years ago

F4bwDP6a6W commented 9 years ago

I have add a new method setBaseURL(String baseUrl, CookieManager cookiemanager) into SyncProxy.java, and modify populatePolicyMap() to populatePolicyMap(CookieManager cookieManager). In the method setBaseURL(String baseUrl) body, I set the DEFAULT_COOKIE_MANAGER into populatePolicyMap(DEFAULT_COOKIE_MANAGER). So if any project only wants to use setBaseURL(String baseUrl), this change will not bring any impact to them. And I have modified RpcPolicyFinder.java accordingly. These modification has been tested in my local environment.

jcricket commented 9 years ago

Overall looks pretty good, thanks for the PR. I'll get it integrated for the 0.6 release (hopefully the next few weeks)