jcristovao / newtype-generics

A typeclass and set of functions for working with newtypes.
10 stars 11 forks source link

Remove version bounds for testsuite to create compatibility with hspec-2.4, add stack.yaml #12

Closed sjakobi closed 7 years ago

sjakobi commented 7 years ago

IMO, version bounds in the testsuite are less important as they don't impact dependency resolution for packages that depend on newtype-generics.

@jcristovao: BTW I'd be interested in becoming a co-maintainer of this package. I could take care of fixing compatibility issues such as this one and triage the occasional issue or PR.

sjakobi commented 7 years ago

Once newtype-generics is compatible with hspec-2.4, tests on Stackage should be un-skipped.

niteria commented 7 years ago

I accidentally duplicated part of this in #14.

@sjakobi any luck in becoming co-maintainer? diagrams-contrib depends on this package transitively, we will have a hard time getting it on GHC 8.2 unless #14 gets merged

@jcristovao ping

sjakobi commented 7 years ago

@niteria: @jcristovao has added me as a maintainer. I've already uploaded v0.5.0.1.