search

jcrobak / parquet-python

python implementation of the parquet columnar file format.
Apache License 2.0
340 stars 257 forks source link

fixed boolean reading #65

Open apesti opened 6 years ago

apesti commented 6 years ago

Couldn't read booleans because they were set to 0 in the thrift file which would then evaluate to False when checking their truth value. Changed it so it specifically checks whether the type is None.

jcrobak commented 6 years ago

thanks for the fix - do you happen to have a simple test case that we can add?

I'll look into why the CI build failed; it seems unrelated.

apesti commented 6 years ago

Sorry I don't have one and I couldn't figure out how to make one for this but any small parquet file with booleans should work as a test case.