search

jcrodriguez-dis / moodle-mod_vpl

Virtual Programming Lab for Moodle (Module)
GNU General Public License v3.0
98 stars 85 forks source link

V3.4dev Fix for issue #106 #107

Closed LennardF1989 closed 3 years ago

LennardF1989 commented 4 years ago

Fixes certain situations where tokens should be cloned, rather than reassigned as reported through #106.

Can be painlessly rebased/cherrypicked on top of the v3.3.7 branch if needed for a v3.3.8 release.

jcrodriguez-dis commented 4 years ago

Dear @LennardF1989r, thanks very much for your bug report and fix. This bug has been here silent for a long time.

Only one question about your code: do you think it would be better to use the PHP clone instruction instead of the method clone_token?

Best regards, Juan Carlos.

LennardF1989 commented 4 years ago

I would stay with the clone_token as it does multiple things at once: