search

jcrodriguez-dis / moodle-mod_vpl

Virtual Programming Lab for Moodle (Module)
GNU General Public License v3.0
100 stars 87 forks source link

Unlocking activity completion options does not work #162

Closed Astor-Bizard closed 8 months ago

Astor-Bizard commented 8 months ago

When setting activity completion conditions such as "Student must receive a grade to complete this activity" / "Student must receive a passing grade to complete this activity", teachers can not edit them anymore after a student has completed the activity, even when clicking "Unlock completion settings" (the settings are not saved afterwards).

jcrodriguez-dis commented 8 months ago

We've successfully replicated the issue described in Bug #162 regarding the inability to edit activity completion conditions after a student completes an activity. After ussing "Unlock completion settings" the changes to activity completion options were not saved.

Upon reviewing the pull request submitted by Astor-Bizard. The tests confirm that the patch resolves the problem, allowing teachers to modify activity completion conditions post-completion by students, as intended.

Consequently, the pull request linked to this fix is approved for merge.

We appreciate @Astor-Bizard 's contribution to addressing this issue in the Moodle VPL module.