jcrodriguez-dis / moodle-mod_vpl

Virtual Programming Lab for Moodle (Module)
GNU General Public License v3.0
99 stars 85 forks source link

Run and Debug operations are restricted by "Maximum execution time" setting #49

Open rhobincu opened 7 years ago

rhobincu commented 7 years ago

I assume that the "Maximum execution time" setting is designed in order to limit the max execution time during evaluation so that only a particular time complexity solution is marked as correct. However, the run and debug operations are also limited by this setting making debugging almost impossible when the time is short (e.g. 1 minute).

Solutions:

  1. Make the run or debug time unlimited.
  2. Add separate settings for max run time and max debug time.
jcrodriguez-dis commented 7 years ago

hello Yes, this is a known issue. But nobody requested to solve it until now. Notice that all the limits are to avoid that a student's program drain the resources (by fail or crafted with this intention). The question here is how to keep the limits and allow debugging for a large time. If I have my own execution server, I can control the problem or accept the effects, but in a shared execution server it may be a big problem. I will take into account this problem for future developments.

rhobincu commented 7 years ago

The separate settings for timeout for run/debug/evaluate should help. We can then choose 1 second for evaluate, 1 minute for run (so the user can input data) and 15 minutes for debug.

rhobincu commented 7 years ago

Also, for Evaluate, it would help immensely to be able to configure it to the second instead of only choosing a duration from a list.