Missing linebreaks in evaluation output

[t-schroeder]

We have this test case:

Case = Test 1
output = "Hello World!
"

... and this solution:

#include <stdio.h>

void main(void) {
    printf("Hello World!");
    return 0;
}

... leads to this output when evaluated:

The problem is that it isn't obvious to the user what's wrong with his solution. When you add a \n to the end of the printf your solution will evaluate as correct. The reason for the empty line being skipped in the expected output is this function: https://github.com/jcrodriguez-dis/moodle-mod_vpl/blob/3842307010be49a71a934dbd772c6fe77c7a72d4/jail/default_scripts/vpl_evaluate.cpp#L368-L391

I don't know if the Tools::splitLines function can just be changed. It is also used in Evaluation::loadTestCases and I can't tell if it would lead to any problems there.

[jcrodriguez-dis]

Hello, Thanks for your sharing your issue. I think that the test program is correcto. If you want to accept only the output with newline the case definition is correct. Please, remember to state it at problem definition. If you want also accept the output whitout newline add a new output to the case definitivo. output = "Hello World! " output = "Hello World!"

I think that the real problem is that the report does not state clearly the difference found. I think that the error report must be improved to help with this problem.

Best regards, Juan Carlos

[t-schroeder]

Hello Juan Carlos,

yes, that's what I meant. In the problem definition we would write something like:

Write a program that outputs "Hello World!" (without the quotes) followed by a newline.

The only problem is that the linebreak is missing in the evaluate output.

Regards Tim Schroeder

[jcrodriguez-dis]

The scrollbars seems to be hiding the real content. I have tagged the issue as bug.