feat: add dockefile - Githubissues

GabrielBdeC commented 1 year ago

This pull request aims to add a dockerfile with installation of docker It can be configurable using environment variables to self signed certificates, ports and secret pass

I'll create a pull request for the plugin integrating with this image too

jeroenhabets commented 1 year ago

@jcrodriguez-dis I would also be very interested in using Docker as an installation method. What are your thoughts on this PR by @GabrielBdeC ?

jeroenhabets commented 12 months ago

@jcrodriguez-dis in full appreciation of your work, I'll try again to bring this PR your attentions.

As for our customers it would be much simpler to host, install and update VPL Jail if it were running inside a Docker container. We're finally about to go live with VPL Jail 3.0.1 via JSON RPC.

Is there any chance this PR by @GabrielBdeC will be merged and released soon(ish)? Can we contribute some how to get this merged sooner?

Thanks again!

kristian-94 commented 10 months ago

Thanks for your work on this, it'll be very useful to use this image rather than manually installing everything. Do you have a prebuilt image on docker hub already that we can use in the meantime?

That's because when running this build on my machine (m1 macbook with docker build -t vpl-jail --platform linux/amd64 .) I get an error, looks like when installing mono-complete

Updating Mono key store
122.6 TYPE: 6
122.6 V: mono_thread_interruption_checkpoint
122.6 * Assertion at ../../mono/arch/amd64/../x86/x86-codegen.h:410, condition `offset == (gint32)offset' not met

GabrielBdeC commented 10 months ago

@kristian-94: https://hub.docker.com/r/gabrielbdec/vpl-jail

jeroenhabets commented 10 months ago

That's because when running this build on my machine (m1 macbook with docker build -t vpl-jail --platform linux/amd64 .) I get an error, looks like when installing mono-complete

P.S. @kristian-94 I had run into that myself and had already logged a request to replace mono with dotnet: https://github.com/jcrodriguez-dis/vpl-xmlrpc-jail/issues/67

jeroenhabets commented 8 months ago

@jcrodriguez-dis in full appreciation of your work, would you be able to share what is stopping you from progressing on this? Anything we can do to help?

jcrodriguez-dis commented 6 months ago

Thank you to all contributors, especially @GabrielBdeC, for your valuable insights and efforts. As someone initially unfamiliar with Docker, I faced challenges in evaluating and integrating the suggested modifications. Nevertheless, recognizing Docker's importance has led to significant enhancements in VPL's functionality. I am excited to announce that VPL version 4.0.0 now fully supports Docker, offering diverse configurations, including support for certificates from Let's Encrypt. For more details, please refer to the release notes. A comprehensive manual will be available soon.

Issue with Mono: In VPL version 4.0.0, the jail installer has been updated. We now utilize external files listing the packages required for different package managers: APT, DNF, and APK. The format for each line in these files is: "Human-readable name" package1 package2 package3 Each line installs the first available package from the list. As I am not an expert in .NET, I am unsure whether adding .NET packages necessitates changes to the compiler or run launcher in the VPL Moodle plugin.

Your ongoing contributions and feedback are integral to VPL's continuous development and improvement. Thank you for your commitment and support.

jeroenhabets commented 4 months ago

@jcrodriguez-dis, @GabrielBdeC would it not be better/clearer to now close this PR (abandon it without merging) as VPL version 4.0.0 now fully supports Docker?

(See also previous comment by @jcrodriguez-dis https://github.com/jcrodriguez-dis/vpl-jail-system/pull/64#issuecomment-1863607637)

I am excited to announce that VPL version 4.0.0 now fully supports Docker

jcrodriguez-dis / vpl-jail-system

feat: add dockefile #64