More polished code and allowing the insertion of multiple lines in a single call

[jcrodriguezt]

Hello, sorry for not getting to this earlier. Could you please share with me what issues were you trying to address with this improvement? I mean, the multiple lines part of your comment.

I'm glad for your code cleanup.. I've been a little bit to lazy to dedicate some time to it. I just made it work for my needs which I don't think are too special.

[xBu3n0]

Hi, thanks for merging the branch, the changes I made were because I'm using it and I wanted to use more tools that Laravel provides but it wasn't possible with the old library, and as I used your branch as a base, I made the pull request so that other people can use. In the comments section it was so that, if someone else tries to use it, know that it will not be possible with the current update (it was not possible in the old version either)

[jcrodriguezt]

Have you tried whereBetween clauses? In many cases it's not working. I've had not much time to debug it yet

On Fri, Feb 9, 2024, 10:01 AM Bueno @.***> wrote:

Hi, thanks for merging the branch, the changes I made were because I'm using it and I wanted to use more tools that Laravel provides but it wasn't possible with the old library, and as I used your branch as a base, I made the pull request so that other people can use. In the comments section it was so that, if someone else tries to use it, know that it will not be possible with the current update (it was not possible in the old version either)

— Reply to this email directly, view it on GitHub https://github.com/jcrodriguezt/laravel-sybase/pull/11#issuecomment-1936085856, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXO35G7MSD3MCSYBT5T37TYSY23XAVCNFSM6AAAAABAMSAX36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZWGA4DKOBVGY . You are receiving this because you modified the open/close state.Message ID: @.***>

[xBu3n0]

No, I hadn't tested this version that you accepted, but this morning's update is already working with ->between and ->notBetween

[jcrodriguezt]

Oh, I see. I'll give it a try and if anything changes I'll let you know.

On Thu, Feb 15, 2024, 7:18 AM Bueno @.***> wrote:

No, I hadn't tested this version that you accepted, but this morning's update is already working with ->between and ->notBetween

— Reply to this email directly, view it on GitHub https://github.com/jcrodriguezt/laravel-sybase/pull/11#issuecomment-1945985327, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXO35EOIMU6ETWJZ6R2CNDYTX4JJAVCNFSM6AAAAABAMSAX36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBVHE4DKMZSG4 . You are receiving this because you modified the open/close state.Message ID: @.***>

[xBu3n0]

I closed the merge of this functionality because with each update I am doing the merge, possibly polluting the fork due to the delay in merges, if I want to use the resources I find it easier to use my branch, for my control too, any functionality you want and/or problems encountered comment in xBu3n0/laravel-sybase.

[jcrodriguezt]

Actually I was thinking about a collab ..let me know what you think

On Thu, Feb 15, 2024, 9:01 AM Bueno @.***> wrote:

I closed the merge of this functionality because with each update I am doing the merge, possibly polluting the fork due to the delay in merges, if I want to use the resources I find it easier to use my branch, for my control too, any functionality you want and/or problems encountered comment in xBu3n0/laravel-sybase.

— Reply to this email directly, view it on GitHub https://github.com/jcrodriguezt/laravel-sybase/pull/11#issuecomment-1946157278, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXO35CM63TK7DNDCQQP2Y3YTYINPAVCNFSM6AAAAABAMSAX36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBWGE2TOMRXHA . You are receiving this because you modified the open/close state.Message ID: @.***>

[xBu3n0]

It's a collaboration, people who are using your library can take advantage of what I wrote, and the way I wrote it, people can make changes more easily, but I have already rewrote almost the entire library, and for the work I would like to leave it on my profile without depending on merging others (even more so due to the delay in the merge process and me not having control of future updates (e.g. The merge of the simple null: instead of : on the last pull request, a small error, but because it's not from my branch it gets stuck)).

In the end it will look like my code on your profile/branch but outdated.

[jcrodriguezt]

No problem, I understand. Thanks for your help

On Thu, Feb 15, 2024, 9:20 AM Bueno @.***> wrote:

It's a collaboration, people who are using your library can take advantage of what I wrote, and the way I wrote it, people can make changes more easily, but I have already rewrote almost the entire library, and for the work I would like to leave it on my profile without depending on merging others (even more so due to the delay in the merge process and me not having control of future updates (e.g. The merge of the simple null: instead of : on the last pull request, a small error, but because it's not from my branch it gets stuck))

— Reply to this email directly, view it on GitHub https://github.com/jcrodriguezt/laravel-sybase/pull/11#issuecomment-1946192078, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXO35CJD2F57IMK3SKWEULYTYKSXAVCNFSM6AAAAABAMSAX36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBWGE4TEMBXHA . You are receiving this because you modified the open/close state.Message ID: @.***>