jcrozum / pystablemotifs

Python library for attractor identification and control in Boolean networks
MIT License
28 stars 7 forks source link

Better handling of source nodes #10

Closed jcrozum closed 4 years ago

jcrozum commented 4 years ago

Source node stable motifs should all be merged to help avoid clutter and combinatorial explosion.

With N source nodes, we have 2N stable motifs and 2^N combinations that result in (2^N) (N!)^2 nodes in the succession diagram. Better to merge these into the 2^N unique combinations from the start to save a factor of (N!)^2 in the diagram size.

jcrozum commented 4 years ago

Now, by default, stable motifs corresponding to source nodes are merged and used for reduction before any other motifs. Primary stable motifs (i.e., not conditionally stable motifs) that exist for all input configurations are stored and printed in the motif reduction summary.

rekaalbert commented 4 years ago

I really like the new implementation!

On Tue, Mar 10, 2020 at 3:05 PM Jordan Rozum notifications@github.com wrote:

Now, by default, stable motifs corresponding to source nodes are merged and used for reduction before any other motifs. Primary stable motifs (i.e., not conditionally stable motifs) that exist for all input configurations are stored and printed in the motif reduction summary.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jcrozum/StableMotifs/issues/10?email_source=notifications&email_token=ADLEUXIBHPEP5NBLIYNMBZLRG2FP3A5CNFSM4LD5MGX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOMXQBQ#issuecomment-597260294, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLEUXJTMIXJBJ4CXGXAFZTRG2FP3ANCNFSM4LD5MGXQ .

-- Reka Albert Distinguished Professor of Physics and Biology Pennsylvania State University 104 Davey Laboratory, PMB 261 University Park, PA 16802 Phone: (814) 865-1141 Web: https://www.ralbert.me https://www.ralbert.me

jgtz commented 4 years ago

When I saw this, I was trying to think what was the best thing to do with treating signal-independent stable motifs. Some stable motifs might be signal-independent, while some might be independent on only a subset of the signals. I think what you are implementing (doing only completely signal-independent ones, and then reducing all source nodes) is the best trade-off.