jcrozum / pystablemotifs

Python library for attractor identification and control in Boolean networks
MIT License
28 stars 7 forks source link

Check new version of PyBoolNet #40

Closed jcrozum closed 4 years ago

jcrozum commented 4 years ago

PyBoolNet has had an update. Does everything still works in the latest version on all OSes? I think they've fixed the networkx issue (#12) and made some changes to how the executables are used (I'm not sure though).

deriteidavid commented 4 years ago

Do you mean version 2.2.8 or something later (in pip this is the latest version)

jcrozum commented 4 years ago

My mistake; they have not packaged the changes into a new release (yet). Their main branch has the updates though. See https://github.com/hklarner/PyBoolNet/pull/35. I guess there's nothing we need to do right now after all, other than to keep a lookout for this to get released.

aurelien-naldi commented 4 years ago

Indeed it should now work with newer versions of networkx. The change for the use of executables should NOT affect pyboolnet itself, at least for now. This is only groundwork to provide a conda package, allowing to use shared executables from separate packages instead of keeping a private copy.

jcrozum commented 4 years ago

Okay, that's good to know. Thanks for the info! I'll close this issue.